Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't issue a warning when replacing an optional dependent with non-null values #27136

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Don't issue a warning when replacing an optional dependent with non-null values #27136

merged 1 commit into from
Jan 7, 2022

Conversation

AndriySvyryd
Copy link
Member

Fixes #26712

@AndriySvyryd AndriySvyryd requested a review from a team January 7, 2022 01:17
@AndriySvyryd AndriySvyryd merged commit 8cdcf30 into main Jan 7, 2022
@AndriySvyryd AndriySvyryd deleted the Issue26712 branch January 7, 2022 20:59
@ajcvickers ajcvickers mentioned this pull request Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect optional dependent (owned type) warning when saving optional dependent with the _same_ data
2 participants
@AndriySvyryd @smitpatel